Comments on: Good and Not So Good Rails Code

By: Dan Croak

Dan Croak — Tue, 19 Jan 2010 05:06:06 +0000

Check out let-it-be for DRYing up the controller action example:

Foobar — Thu, 09 Jul 2009 00:14:08 +0000

also try

render :partial => @books

dude — Fri, 26 Jun 2009 15:13:33 +0000

Ahh, jakehow beat me to it. With activesupport the (&:name) syntax is very nice indeed!

dude — Fri, 26 Jun 2009 15:13:07 +0000

Why not, for array of book titles:

def all_titles( books )
books.map { |book| book.name }
end

Cleaner, simpler… Inject isn’t very useful here, it just ads extra syntax for no reason :)

jakehow — Fri, 26 Jun 2009 15:10:56 +0000

Abuse of inject is pretty rampant.

Better solution:

def all_titles(books)
books.map {|book| book.name }
end

or even:

def all_titles(books)
books.map(&:name)
end